Modernize HTML markup in phpinfo output#22370
Conversation
| php_info_print(PHP_EGG_LOGO_DATA_URI "\" alt=\"PHP logo\" /></a>"); | ||
| php_info_print(PHP_EGG_LOGO_DATA_URI "\" alt=\"PHP logo\"></a>"); |
There was a problem hiding this comment.
I'm not sure I agree with removing the the / to indicate an empty tag.
There was a problem hiding this comment.
I believe it's better to not use the self closing variant. As "Self-closing tags () do not exist in HTML.".
This is acceptable by XHTML standards only.
https://developer.mozilla.org/en-US/docs/Glossary/Void_element#self-closing_tags
There was a problem hiding this comment.
sigh, I do kinda hate the HTML spec at times.
TimWolla
left a comment
TimWolla
left a comment
There was a problem hiding this comment.
This mixes functional changes (explicit charset) with non-functional changes - and overall feels like change for the sake of change. Is there some expected follow-up?
|
I actually stumbled on the fact that phpinfo was still emitting the XHTML 1.0 variant while testing locally, and was a bit surprised it hadn’t been moved to HTML5 yet. The charset line is encouraged by the HTML spec and No follow-up expected. This is just bumping the HTML to modern standards. |
3 participants
No description provided.